* [sup-devel] [PATCH] fix ask_for_contacts on Ruby 1.9
@ 2010-01-13 18:13 Rich Lane
2010-01-23 12:41 ` William Morgan
0 siblings, 1 reply; 2+ messages in thread
From: Rich Lane @ 2010-01-13 18:13 UTC (permalink / raw)
To: sup-devel; +Cc: Rich Lane
From: Rich Lane <rlane@vmware.com>
String doesn't respond to :map anymore. The previous code was also joining with
" " instead of ", ", which was broken.
---
lib/sup/buffer.rb | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lib/sup/buffer.rb b/lib/sup/buffer.rb
index c826ab9..990dd4a 100644
--- a/lib/sup/buffer.rb
+++ b/lib/sup/buffer.rb
@@ -537,7 +537,7 @@ EOS
end
def ask_for_contacts domain, question, default_contacts=[]
- default = default_contacts.map { |s| s.to_s }.join(" ")
+ default = default_contacts.is_a?(String) ? default_contacts : default_contacts.map { |s| s.to_s }.join(", ")
default += " " unless default.empty?
recent = Index.load_contacts(AccountManager.user_emails, :num => 10).map { |c| [c.full_address, c.email] }
--
1.6.3.3
_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [sup-devel] [PATCH] fix ask_for_contacts on Ruby 1.9
2010-01-13 18:13 [sup-devel] [PATCH] fix ask_for_contacts on Ruby 1.9 Rich Lane
@ 2010-01-23 12:41 ` William Morgan
0 siblings, 0 replies; 2+ messages in thread
From: William Morgan @ 2010-01-23 12:41 UTC (permalink / raw)
To: sup-devel
Applied to master and will go out in 0.10. Thanks!
--
William <wmorgan-sup@masanjin.net>
_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-01-23 12:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-01-13 18:13 [sup-devel] [PATCH] fix ask_for_contacts on Ruby 1.9 Rich Lane
2010-01-23 12:41 ` William Morgan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox