[sup-devel] [PATCHv3] [issue14] poll updates accumulate while idle

From: Eric Sherman <hyperbolist@gmail.com>
To: sup-devel <sup-devel@rubyforge.org>
Subject: [sup-devel] [PATCHv3] [issue14] poll updates accumulate while idle
Date: Tue, 12 Jan 2010 09:56:21 -0500	[thread overview]
Message-ID: <1263308149-sup-5426@changeling.local> (raw)
In-Reply-To: <1263307713-sup-7005@changeling.local>

If you were to leave sup running for a long time, this patch would
enable you to get a glance summary of new mail activity since sup was
last touched, by letting the poll update message accumulate its totals
while idle.

On keystrokes, BufferManager sends an :unidle update if the last
keystroke occurred more than :idle_threshold seconds ago.  PollManager
listens for :unidle updates to clear @running_totals, which is also
cleared on each poll unless idle.

* :idle_threshold defaults to 60 seconds if not defined in config.yaml
* presently no :idle update is sent when becoming idle
* but we can check for idleness with BufferManager.idle?
* after-poll behavior is unaffected
---
 lib/sup.rb        |    3 ++-
 lib/sup/buffer.rb |    5 +++++
 lib/sup/poll.rb   |   13 +++++++++++--
 3 files changed, 18 insertions(+), 3 deletions(-)

diff --git a/lib/sup.rb b/lib/sup.rb
index b83bbe7..e228772 100644
--- a/lib/sup.rb
+++ b/lib/sup.rb
@@ -230,7 +230,8 @@ else
     :discard_snippets_from_encrypted_messages => false,
     :default_attachment_save_dir => "",
     :sent_source => "sup://sent",
-    :poll_interval => 300
+    :poll_interval => 300,
+    :idle_threshold => 60
   }
   begin
     FileUtils.mkdir_p Redwood::BASE_DIR
diff --git a/lib/sup/buffer.rb b/lib/sup/buffer.rb
index c826ab9..2f5eaa8 100644
--- a/lib/sup/buffer.rb
+++ b/lib/sup/buffer.rb
@@ -212,6 +212,7 @@ EOS
     @in_x = ENV["TERM"] =~ /(xterm|rxvt|screen)/
     @sigwinch_happened = false
     @sigwinch_mutex = Mutex.new
+    @no_keystrokes_since = Time.now
   end
 
   def sigwinch_happened!; @sigwinch_mutex.synchronize { @sigwinch_happened = true } end
@@ -269,6 +270,8 @@ EOS
         @focus_buf.mode.cancel_search!
         @focus_buf.mark_dirty
       end
+      UpdateManager.relay self, :unidle, Time.at(@no_keystrokes_since) if idle?
+      @no_keystrokes_since = Time.now
       @focus_buf.mode.handle_input c
     end
   end
@@ -761,6 +764,8 @@ EOS
     @shelled = false
   end
 
+  def idle?; Time.now.to_i - @no_keystrokes_since.to_i >= ($config[:idle_threshold] || 60); end
+
 private
 
   def default_status_bar buf
diff --git a/lib/sup/poll.rb b/lib/sup/poll.rb
index f3e1224..ad51647 100644
--- a/lib/sup/poll.rb
+++ b/lib/sup/poll.rb
@@ -37,6 +37,8 @@ EOS
     @polling = false
     @poll_sources = nil
     @mode = nil
+    clear_running_totals
+    UpdateManager.register self
   end
 
   def poll_with_sources
@@ -45,8 +47,12 @@ EOS
 
     BufferManager.flash "Polling for new messages..."
     num, numi, from_and_subj, from_and_subj_inbox, loaded_labels = @mode.poll
-    if num > 0
-      BufferManager.flash "Loaded #{num.pluralize 'new message'}, #{numi} to inbox. Labels: #{loaded_labels.map{|l| l.to_s}.join(', ')}"
+    clear_running_totals unless BufferManager.idle?
+    @running_totals[:num] += num
+    @running_totals[:numi] += numi
+    @running_totals[:loaded_labels] += loaded_labels || []
+    if @running_totals[:num] > 0
+      BufferManager.flash "Loaded #{@running_totals[:num].pluralize 'new message'}, #{@running_totals[:numi]} to inbox. Labels: #{@running_totals[:loaded_labels].map{|l| l.to_s}.join(', ')}"
     else
       BufferManager.flash "No new messages." 
     end
@@ -183,6 +189,9 @@ EOS
     Index.add_message m
     UpdateManager.relay self, :added, m
   end
+
+  def handle_unidle_update sender, idle_since; clear_running_totals; end
+  def clear_running_totals; @running_totals = {:num => 0, :numi => 0, :loaded_labels => Set.new}; end
 end
 
 end
-- 
1.6.6
_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel

