From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 10.90.87.14 with SMTP id k14cs1371600agb; Fri, 1 Jan 2010 12:59:08 -0800 (PST) Received: by 10.229.131.102 with SMTP id w38mr2786782qcs.35.1262379548406; Fri, 01 Jan 2010 12:59:08 -0800 (PST) Return-Path: Received: from rubyforge.org (rubyforge.org [205.234.109.19]) by mx.google.com with ESMTP id 36si9049739qyk.126.2010.01.01.12.59.08; Fri, 01 Jan 2010 12:59:08 -0800 (PST) Received-SPF: pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) client-ip=205.234.109.19; Authentication-Results: mx.google.com; spf=pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) smtp.mail=sup-devel-bounces@rubyforge.org Received: from rubyforge.org (rubyforge.org [127.0.0.1]) by rubyforge.org (Postfix) with ESMTP id 1F1CC15B802A; Fri, 1 Jan 2010 15:59:08 -0500 (EST) Received: from mail.cnsp.com (mail.cnsp.com [208.3.80.17]) by rubyforge.org (Postfix) with ESMTP id 330E015B802F for ; Fri, 1 Jan 2010 15:59:06 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mail.cnsp.com (Postfix) with ESMTP id 334B5D432A21 for ; Fri, 1 Jan 2010 13:59:05 -0700 (MST) X-Virus-Scanned: Debian amavisd-new at cnsp.biz Received: from mail.cnsp.com ([127.0.0.1]) by localhost (mail.cnsp.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id PzxEXu7yB6ii for ; Fri, 1 Jan 2010 13:59:05 -0700 (MST) Received: from home.mrtheplague.net (coffeehost.tcct.nmt.edu [129.138.3.50]) by mail.cnsp.com (Postfix) with SMTP id 5BFC6D45B5BA for ; Fri, 1 Jan 2010 13:59:03 -0700 (MST) Received: by home.mrtheplague.net (Postfix, from userid 1000) id E163F84CB3CB; Fri, 1 Jan 2010 13:59:02 -0700 (MST) From: Anthony Martinez X-modeline: vim:tw=80:ft=mail:fo=tcql To: sup-devel In-reply-to: <1262302618-20503-2-git-send-email-rlane@club.cc.cmu.edu> References: <1262302618-20503-1-git-send-email-rlane@club.cc.cmu.edu> <1262302618-20503-2-git-send-email-rlane@club.cc.cmu.edu> Date: Fri, 01 Jan 2010 13:59:02 -0700 Message-Id: <1262378704-sup-5011@home.mrtheplague.net> User-Agent: Sup/git Subject: Re: [sup-devel] [PATCH 01/10] open mail source files as binary X-BeenThere: sup-devel@rubyforge.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: Sup developer discussion List-Id: Sup developer discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: sup-devel-bounces@rubyforge.org Errors-To: sup-devel-bounces@rubyforge.org Excerpts from Rich Lane's message of Thu Dec 31 16:36:49 -0700 2009: > diff --git a/lib/sup/maildir.rb b/lib/sup/maildir.rb > index c2bd27a..0852576 100644 > --- a/lib/sup/maildir.rb > +++ b/lib/sup/maildir.rb > @@ -59,7 +59,7 @@ class Maildir < Source > File.stat(tmp_path) > rescue Errno::ENOENT #this is what we want. > begin > - File.open(tmp_path, 'w') do |f| > + File.open(tmp_path, 'wb:BINARY') do |f| > yield f #provide a writable interface for the caller This patch causes the following warning on Ruby 1.8: warning: encoding options not supported in 1.8: wb:BINARY Especially if you use Maildir for a source, the resulting torrent of warnings makes Sup a bit difficult to use. I've gone and reverted this diff locally for now. I suppose I could also stop running sup with the -w flag... _______________________________________________ Sup-devel mailing list Sup-devel@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-devel