From: Anthony Martinez <pi+sup@pihost.us>
To: sup-devel <sup-devel@rubyforge.org>
Subject: Re: [sup-devel] [PATCH 01/10] open mail source files as binary
Date: Fri, 01 Jan 2010 13:59:02 -0700 [thread overview]
Message-ID: <1262378704-sup-5011@home.mrtheplague.net> (raw)
In-Reply-To: <1262302618-20503-2-git-send-email-rlane@club.cc.cmu.edu>
Excerpts from Rich Lane's message of Thu Dec 31 16:36:49 -0700 2009:
> diff --git a/lib/sup/maildir.rb b/lib/sup/maildir.rb
> index c2bd27a..0852576 100644
> --- a/lib/sup/maildir.rb
> +++ b/lib/sup/maildir.rb
> @@ -59,7 +59,7 @@ class Maildir < Source
> File.stat(tmp_path)
> rescue Errno::ENOENT #this is what we want.
> begin
> - File.open(tmp_path, 'w') do |f|
> + File.open(tmp_path, 'wb:BINARY') do |f|
> yield f #provide a writable interface for the caller
This patch causes the following warning on Ruby 1.8:
warning: encoding options not supported in 1.8: wb:BINARY
Especially if you use Maildir for a source, the resulting torrent of warnings
makes Sup a bit difficult to use.
I've gone and reverted this diff locally for now. I suppose I could also stop
running sup with the -w flag...
_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel
next prev parent reply other threads:[~2010-01-01 20:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-31 23:36 [sup-devel] Ruby 1.9 encoding fixes Rich Lane
2009-12-31 23:36 ` [sup-devel] [PATCH 01/10] open mail source files as binary Rich Lane
2009-12-31 23:36 ` [sup-devel] [PATCH 02/10] display_size is just size on Ruby 1.9 Rich Lane
2009-12-31 23:36 ` [sup-devel] [PATCH 03/10] add String#check Rich Lane
2009-12-31 23:36 ` [sup-devel] [PATCH 04/10] add String#ascii Rich Lane
2009-12-31 23:36 ` [sup-devel] [PATCH 05/10] fixup Iconv#easy_decode for Ruby 1.9 Rich Lane
2009-12-31 23:36 ` [sup-devel] [PATCH 06/10] add String#transcode Rich Lane
2009-12-31 23:36 ` [sup-devel] [PATCH 07/10] transcode output from mime-decode hook too Rich Lane
2009-12-31 23:36 ` [sup-devel] [PATCH 08/10] decode raw header/message to ascii before viewing Rich Lane
2009-12-31 23:36 ` [sup-devel] [PATCH 09/10] use header from the RMail::Message in Message#parse_header Rich Lane
2009-12-31 23:36 ` [sup-devel] [PATCH 10/10] decode header fields of enclosed messages Rich Lane
2010-01-01 20:59 ` Anthony Martinez [this message]
2010-01-01 21:43 ` [sup-devel] [PATCH 01/10] open mail source files as binary William Morgan
2010-01-01 21:48 ` Rich Lane
2010-01-01 21:57 ` William Morgan
2010-01-02 1:16 ` Anthony Martinez
2010-01-01 19:09 ` [sup-devel] Ruby 1.9 encoding fixes William Morgan
[not found] ` <1262442839-sup-7738@peray>
2010-01-03 14:48 ` William Morgan
2010-01-03 15:48 ` Nicolas Pouillard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1262378704-sup-5011@home.mrtheplague.net \
--to=pi+sup@pihost.us \
--cc=sup-devel@rubyforge.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox