From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 10.90.87.14 with SMTP id k14cs1323122agb; Thu, 31 Dec 2009 11:42:15 -0800 (PST) Received: by 10.224.1.229 with SMTP id 37mr6560374qag.127.1262288535130; Thu, 31 Dec 2009 11:42:15 -0800 (PST) Return-Path: Received: from rubyforge.org (rubyforge.org [205.234.109.19]) by mx.google.com with ESMTP id 13si22112049qyk.131.2009.12.31.11.42.15; Thu, 31 Dec 2009 11:42:15 -0800 (PST) Received-SPF: pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) client-ip=205.234.109.19; Authentication-Results: mx.google.com; spf=pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) smtp.mail=sup-devel-bounces@rubyforge.org Received: from rubyforge.org (rubyforge.org [127.0.0.1]) by rubyforge.org (Postfix) with ESMTP id C0D6419782DB; Thu, 31 Dec 2009 14:42:14 -0500 (EST) Received: from entry.masanjin.net (masanjin.net [209.20.72.13]) by rubyforge.org (Postfix) with ESMTP id 0C2F41858267 for ; Thu, 31 Dec 2009 14:41:16 -0500 (EST) Received: from w by entry.masanjin.net with local (Exim 4.69) (envelope-from ) id 1NQQtY-000298-Hy for sup-devel@rubyforge.org; Thu, 31 Dec 2009 11:41:16 -0800 From: William Morgan To: sup-devel In-reply-to: <1262190807-sup-434@zyrg.net> References: <1261485246-sup-4236@tilus.net> <1261938751-sup-9421@zyrg.net> <1262136474-sup-312@tilus.net> <1262182085-sup-1405@masanjin.net> <1262190807-sup-434@zyrg.net> Date: Thu, 31 Dec 2009 11:41:16 -0800 Message-Id: <1262287125-sup-5933@masanjin.net> User-Agent: Sup/git Subject: Re: [sup-devel] [PATCH] XapianIndex.each_message_in_thread_for yields messages in cronological order X-BeenThere: sup-devel@rubyforge.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: Sup developer discussion List-Id: Sup developer discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: sup-devel-bounces@rubyforge.org Errors-To: sup-devel-bounces@rubyforge.org Reformatted excerpts from Rich Lane's message of 2009-12-30: > I'm assuming you're talking about each_message_in_thread_for, since > that's the only Index method that deals with threading. Yes, I suppose. In my mind the Xapian index had replaced the ThreadSet threading entirely, but perhaps that's not the case. > In what order does ThreadSet#add_message expect to get messages in? Arbitrary. > AFAICT JWZ's algorithm should work regardless of the order messages > handed to it. That's my understanding too. I don't like adding date as a component for threading (because it's just asking for a screwey date to wreak havok, just as a screwey References: header wreaks havok now). I don't like playing around with the threading algorithm, not in the least because we don't have a good test harness that lets us know if we screw something up. So I'm inclined to sit on this patch. Out of curiousity, Tero, could the problem also be solved by giving the in-reply-to header precedence over the references header? -- William _______________________________________________ Sup-devel mailing list Sup-devel@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-devel