Archive of RubyForge sup-devel mailing list
 help / color / mirror / Atom feed
From: William Morgan <wmorgan-sup@masanjin.net>
To: sup-devel <sup-devel@rubyforge.org>
Subject: Re: [sup-devel] [PATCH] XapianIndex.each_message_in_thread_for yields messages in cronological order
Date: Thu, 31 Dec 2009 11:41:16 -0800	[thread overview]
Message-ID: <1262287125-sup-5933@masanjin.net> (raw)
In-Reply-To: <1262190807-sup-434@zyrg.net>

Reformatted excerpts from Rich Lane's message of 2009-12-30:
> I'm assuming you're talking about each_message_in_thread_for, since
> that's the only Index method that deals with threading.

Yes, I suppose. In my mind the Xapian index had replaced the ThreadSet
threading entirely, but perhaps that's not the case.

> In what order does ThreadSet#add_message expect to get messages in?

Arbitrary.

> AFAICT JWZ's algorithm should work regardless of the order messages
> handed to it.

That's my understanding too.

I don't like adding date as a component for threading (because it's just
asking for a screwey date to wreak havok, just as a screwey References:
header wreaks havok now). I don't like playing around with the threading
algorithm, not in the least because we don't have a good test harness
that lets us know if we screw something up. So I'm inclined to sit on
this patch.

Out of curiousity, Tero, could the problem also be solved by giving the
in-reply-to header precedence over the references header?
-- 
William <wmorgan-sup@masanjin.net>
_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel


  reply	other threads:[~2009-12-31 19:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1261485246-sup-4236@tilus.net>
2009-12-27 21:37 ` Rich Lane
2009-12-30  2:41   ` Tero Tilus
2009-12-30 14:10     ` William Morgan
2009-12-30 17:01       ` Rich Lane
2009-12-31 19:41         ` William Morgan [this message]
2010-01-01 13:19           ` Tero Tilus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1262287125-sup-5933@masanjin.net \
    --to=wmorgan-sup@masanjin.net \
    --cc=sup-devel@rubyforge.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox