Archive of RubyForge sup-devel mailing list
 help / color / mirror / Atom feed
From: Rich Lane <rlane@club.cc.cmu.edu>
To: sup-devel@rubyforge.org
Subject: [sup-devel] [PATCH 2/4] async thread indexing
Date: Tue, 29 Dec 2009 17:38:03 -0800	[thread overview]
Message-ID: <1262137085-25928-2-git-send-email-rlane@club.cc.cmu.edu> (raw)
In-Reply-To: <1262137085-25928-1-git-send-email-rlane@club.cc.cmu.edu>

---
 bin/sup                            |    2 ++
 lib/sup/index.rb                   |   26 +++++++++++++++++++++++++-
 lib/sup/modes/thread-index-mode.rb |    2 +-
 3 files changed, 28 insertions(+), 2 deletions(-)

diff --git a/bin/sup b/bin/sup
index 471e833..f9ed7d5 100755
--- a/bin/sup
+++ b/bin/sup
@@ -141,6 +141,7 @@ Index.lock_interactively or exit
 begin
   Redwood::start
   Index.load
+  Index.start_sync_worker unless $opts[:no_threads]
 
   $die = false
   trap("TERM") { |x| $die = true }
@@ -329,6 +330,7 @@ ensure
 
   HookManager.run "shutdown"
 
+  Index.stop_sync_worker
   Redwood::finish
   stop_cursing
   Redwood::Logger.remove_all_sinks!
diff --git a/lib/sup/index.rb b/lib/sup/index.rb
index 5d8d714..1131ec7 100644
--- a/lib/sup/index.rb
+++ b/lib/sup/index.rb
@@ -28,6 +28,8 @@ class BaseIndex
   def initialize dir=BASE_DIR
     @dir = dir
     @lock = Lockfile.new lockfile, :retries => 0, :max_age => nil
+    @sync_worker = nil
+    @sync_queue = Queue.new
   end
 
   def lockfile; File.join @dir, "lock" end
@@ -175,10 +177,32 @@ class BaseIndex
 
   def save_thread t
     t.each_dirty_message do |m|
-      update_message_state m 
+      if @sync_worker
+        @sync_queue << m
+      else
+        update_message_state m
+      end
       m.clear_dirty
     end
   end
+
+  def start_sync_worker
+    @sync_worker = Redwood::reporting_thread('index sync') { run_sync_worker }
+  end
+
+  def stop_sync_worker
+    return unless worker = @sync_worker
+    @sync_worker = nil
+    @sync_queue << :die
+    worker.join
+  end
+
+  def run_sync_worker
+    while m = @sync_queue.deq
+      return if m == :die
+      update_message_state m
+    end
+  end
 end
 
 index_name = ENV['SUP_INDEX'] || $config[:index] || DEFAULT_INDEX
diff --git a/lib/sup/modes/thread-index-mode.rb b/lib/sup/modes/thread-index-mode.rb
index c4a7d38..f6ea27c 100644
--- a/lib/sup/modes/thread-index-mode.rb
+++ b/lib/sup/modes/thread-index-mode.rb
@@ -477,7 +477,7 @@ EOS
       BufferManager.say("Saving threads...") do |say_id|
         dirty_threads.each_with_index do |t, i|
           BufferManager.say "Saving modified thread #{i + 1} of #{dirty_threads.length}...", say_id
-          Index.save_thread t
+          Index.save_thread_async t
         end
       end
     end
-- 
1.6.3.3

_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel


  reply	other threads:[~2009-12-30  1:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-30  1:38 [sup-devel] [PATCH 1/4] factor saving out of thread/message classes Rich Lane
2009-12-30  1:38 ` Rich Lane [this message]
2009-12-30  1:38   ` [sup-devel] [PATCH 3/4] immediate thread indexing Rich Lane
2009-12-30  1:38     ` [sup-devel] [PATCH 4/4] force the index sync thread to give up the cpu Rich Lane
2009-12-31 20:09 ` [sup-devel] [PATCH 1/4] factor saving out of thread/message classes William Morgan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1262137085-25928-2-git-send-email-rlane@club.cc.cmu.edu \
    --to=rlane@club.cc.cmu.edu \
    --cc=sup-devel@rubyforge.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox