From: Dan Callaghan <dan@bl2.djc.id.au>
To: sup-commits@supmua.dev
Subject: [sup.git] 04/04: don't fix_encoding! in Message#indexable_body
Date: Sun, 19 Jul 2026 18:11:19 +1000 [thread overview]
Message-ID: <20260719081116.31FE7218208@bl2.djc.id.au> (raw)
In-Reply-To: <178444867564.48613.6024460618149236020@bl2.djc.id.au>
New commit on branch develop:
https://supmua.dev/git/sup/commit/c20d8fe5972b7616c3f45873d5d7a2c7c4a12381.html
commit c20d8fe5972b7616c3f45873d5d7a2c7c4a12381
Author: Dan Callaghan <djc@djc.id.au>
AuthorDate: Sun May 3 21:12:29 2026 +1000
don't fix_encoding! in Message#indexable_body
The message chunks are already properly encoded so calling
fix_encoding! again on every chunk is just wasting CPU time.
---
lib/sup/message.rb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/sup/message.rb b/lib/sup/message.rb
index 72921ac5..35f78256 100644
--- a/lib/sup/message.rb
+++ b/lib/sup/message.rb
@@ -334,7 +334,7 @@ EOS
end
def indexable_body
- indexable_chunks.map { |c| c.lines }.flatten.compact.map { |l| l.fix_encoding! }.join " "
+ indexable_chunks.map { |c| c.lines }.flatten.compact.join " "
end
def indexable_chunks
prev parent reply other threads:[~2026-07-19 8:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-19 8:11 [sup.git] branch develop updated (246af746 -> c20d8fe5) Dan Callaghan
2026-07-19 8:11 ` [sup.git] 01/04: contrib/nix/gem-install-shell.nix: update to Ruby 4.0 Dan Callaghan
2026-07-19 8:11 ` [sup.git] 02/04: micro-optimisation for Maildir#maildir_labels Dan Callaghan
2026-07-19 8:11 ` [sup.git] 03/04: drop unused indexable_content methods Dan Callaghan
2026-07-19 8:11 ` Dan Callaghan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260719081116.31FE7218208@bl2.djc.id.au \
--to=dan@bl2.djc.id.au \
--cc=djc@djc.id.au \
--cc=sup-commits@supmua.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox