Subject: [sup-talk] [PATCH] Write sup-{exception-log, unable-to-decode}.txt in ~/.sup

From: [email-masked] (Nicolas Pouillard)
Date: Thu, 3 Apr 2008 16:16:19 +0200

More precisely new destinations are:
  - ~/.sup/exception-log.txt
  - ~/.sup/unable-to-decode.txt
This patch avoid some kind of pollution.
---
 bin/sup            |    4 ++--
 lib/sup/message.rb |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/bin/sup b/bin/sup
index 0d34215..a7623de 100644
--- a/bin/sup
+++ b/bin/sup
@@ -327,7 +327,7 @@ ensure
 end
 
 unless $exceptions.empty?
-  File.open("sup-exception-log.txt", "w") do |f|
+  File.open(File.join(BASE_DIR, "exception-log.txt"), "w") do |f|
     $exceptions.each do |e, name|
       f.puts "--- #{e.class.name} from thread: #{name}"
       f.puts e.message, e.backtrace
@@ -337,7 +337,7 @@ unless $exceptions.empty?
 ----------------------------------------------------------------
 I'm very sorry. It seems that an error occurred in Sup. Please
 accept my sincere apologies. If you don't mind, please send the
-contents of sup-exception-log.txt and a brief report of the
+contents of ~/.sup/exception-log.txt and a brief report of the
 circumstances to sup-talk at rubyforge dot orgs so that I might
 address this problem. Thank you!
 
diff --git a/lib/sup/message.rb b/lib/sup/message.rb
index 6a2a9c4..249b6c6 100644
--- a/lib/sup/message.rb
+++ b/lib/sup/message.rb
@@ -423,7 +423,7 @@ private
       Iconv.iconv($encoding + "//IGNORE", charset, body + " ").join[0 .. -2]
     rescue Errno::EINVAL, Iconv::InvalidEncoding, Iconv::IllegalSequence, MessageFormatError => e
       Redwood::log "warning: error (#{e.class.name}) decoding message body from #{charset}: #{e.message}"
-      File.open("sup-unable-to-decode.txt", "w") { |f| f.write body }
+      File.open(File.join(BASE_DIR,"unable-to-decode.txt"), "w") { |f| f.write body }
       body
     end
   end
-- 
1.5.3.1.109.gacd69

---

From: [email-masked] (Giorgio Lando)
Date: Sun, 06 Apr 2008 13:06:55 +0200

> This patch avoid some kind of pollution.

I really enjoy this patch, my home folder is now cleaner! Thanks 

-- 
Giorgio Lando <patroclo7 at gmail dot com>

---

From: [email-masked] (Nicolas Pouillard)
Date: Mon, 21 Apr 2008 10:01:45 +0200

What about applying this patch?

-- 
Nicolas Pouillard aka Ertai
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 194 bytes
Desc: not available
Url : http://rubyforge.org/pipermail/sup-talk/attachments/20080421/e75f4850/attachment.bin

---

From: [email-masked] (William Morgan)
Date: Tue, 22 Apr 2008 18:43:17 -0700

> What about applying this patch?

Applied directly to master, and sorry for the delay.

-- 
William <wmorgan-sup at masanjin.net>

---

From: [email-masked] (Nicolas Pouillard)
Date: Wed, 23 Apr 2008 10:59:46 +0200

> Applied directly to master, and sorry for the delay.

No problem.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 194 bytes
Desc: not available
Url : http://rubyforge.org/pipermail/sup-talk/attachments/20080423/3e0a19cf/attachment.bin