Subject: [sup-talk] skip_killed not getting set in default config

From: [email-masked] (Kevin Riggle)
Date: Wed, 30 Apr 2008 08:14:25 -0400

Hi,

I've just started using Sup, and I quite like it.  It's always wonderful
to discover that someone else has developed *exactly the software you
wanted*, and done such a bang-up job of it.  Thank you!

I have, however, run into a few bugs.  At the moment, the most notable
one is that killed threads would show up in my inbox again, +killed
label and all, which sort of defeats the purpose of killing them.  I
poked around in the source and discovered the skip_killed option, which
inbox-mode seems to initialize to true.  When I added 

:skip_killed: true

to the end of my ~/.sup/config.yaml, which had previously been exactly
as sup-config created it, the killed threads no longer showed up in my
inbox.  I'm not sure if this means that skip_killed needs to be added to
the default config in lib/sup.rb, or if the initialize method on
inbox-mode isn't getting called, or if skip_killed is getting set to
false elsewhere in the code, or something else, but any way it should 
Just Work for new users, and it's not right now.

(I'm running Sup out of git, for reference -- commit
5b9eddb8a949c1a712d53ec8fe163de2848d5ac9.)

- Kevin
-- 
Kevin Riggle (kevinr at mit.edu) 
http://free-dissociation.com

---

From: [email-masked] (William Morgan)
Date: Mon, 19 May 2008 21:42:57 -0700

Reformatted excerpts from Kevin Riggle's message of 2008-04-30:
> I've just started using Sup, and I quite like it.  It's always
> wonderful to discover that someone else has developed *exactly the
> software you wanted*, and done such a bang-up job of it.  Thank you!

Thanks! Welcome aboard.

> label and all, which sort of defeats the purpose of killing them.

Yes, this has been working intermittently and I haven't gotten a chance
to look at the current breakage.

> I poked around in the source and discovered the skip_killed option,
> which inbox-mode seems to initialize to true.  When I added 
> 
> :skip_killed: true
> 
> inbox.

That shouldn't have made a difference. There is a :skip_killed option in
the code, but it's not related to the configuration file. If you grep
for $config you'll see how the config file is used.

(The :skip_killed: internal flag is there only so it can be be turned
off when you're explicitly searching for killed messages.)
-- 
William <wmorgan-sup at masanjin.net>