Subject: [sup-talk] [Patch] From auto completion

From: [email-masked] (Tyberius Prime)
Date: Fri, 02 May 2008 19:50:13 +0200

Hi all,

attached you'll find two patches ment to be applied together (*)
The first one introduces From: auto completion in edit-message 
mode (plus key shortcut "f"),
the second adds a From: question when composing messages
(config ask_for_from, again with auto completion) and improves
the auto completion to be "Name <address>" instead of just "address".

Motivation: I have to send mail from different accounts,
and am tired of typing in the full sender each time.

(*) Sorry, I can't quite get git to export them as one right now :(
Also, I'll bear any comments on my code - this is the first ruby
I've ever written.

So long, 
Tyberius Prime
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0001-Autocomplete-editing-for-from-in-edit-message-mode-and-a-key-shortcut-for-it.txt
URL: <http://rubyforge.org/pipermail/sup-talk/attachments/20080502/70280483/attachment.txt>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0002-add-from-query-on-compose-configuration-option-autocomplete.txt
URL: <http://rubyforge.org/pipermail/sup-talk/attachments/20080502/70280483/attachment-0001.txt>

---

From: [email-masked] (William Morgan)
Date: Sat, 24 May 2008 20:27:36 -0700

Hi Tyberius,

Thanks for the patch. You can merge multiple commits together with git
rebase -i, or you can commit --amend each time to merge current changes
into the previous commit.

I like the idea of this patch, but instead of
AccountManager#user_accounts_autocompletion, could you add a
BufferManager#ask_for_account, similar to #ask_for_contact works? Then
the whole flow will be basically the same as editing the other fields.

Also note that you don't need semicolons at the end of statements in
Ruby. :)
-- 
William <wmorgan-sup at masanjin.net>