Subject: [sup-talk] [PATCH] respond_to? needs include_private argument

From: [email-masked] (Decklin Foster)
Date: Wed, 18 Jun 2008 16:25:56 -0400

Sup started mysteriously bailing out on me today after an apt-get
update with stuff like this:

--- ArgumentError from thread: main
wrong number of arguments (2 for 1)
/usr/lib/ruby/1.8/sup/index.rb:424:in `respond_to?'
/usr/lib/ruby/1.8/sup/index.rb:424:in `flatten'
/usr/lib/ruby/1.8/sup/index.rb:424:in `load_sources'
/usr/lib/ruby/1.8/sup/index.rb:108:in `load'
/usr/lib/ruby/1.8/sup/util.rb:497:in `send'
/usr/lib/ruby/1.8/sup/util.rb:497:in `method_missing'
/usr/bin/sup:122

I did some digging and it seems like when Array#flatten, in attempting
to figure out if it can flatten some list element recursively, sends
it :respond_to? with both arguments -- I didn't even know there was a
second one (defaults to false; see docs). But this only happened recently
or something.

Here's somewhere else this came up:
http://www.ruby-forum.com/topic/154938

So, the fix is exactly the same. Should work fine on old Ruby as well.
Weep for our poor one-liner methods; they just weren't cut out for this
harsh world...

Also: Hi everyone. I am the future Debian maintainer of sup.

---
 lib/sup/util.rb |    8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/lib/sup/util.rb b/lib/sup/util.rb
index ceaf0b8..9909022 100644
--- a/lib/sup/util.rb
+++ b/lib/sup/util.rb
@@ -108,7 +108,9 @@ class Module
   def defer_all_other_method_calls_to obj
     class_eval %{
       def method_missing meth, *a, &b; @#{obj}.send meth, *a, &b; end
-      def respond_to? meth; @#{obj}.respond_to?(meth); end
+      def respond_to?(m, include_private = false)
+        @#{obj}.respond_to?(m, include_private)
+      end
     }
   end
 end
@@ -527,7 +529,9 @@ class Recoverable
   def to_yaml x; __pass :to_yaml, x; end
   def is_a? c; @o.is_a? c; end
 
-  def respond_to? m; @o.respond_to? m end
+  def respond_to?(m, include_private=false)
+    @o.respond_to?(m, include_private)
+  end
 
   def __pass m, *a, &b
     begin
-- 
1.5.5.3

-- 
Decklin Foster <dfoster at wjh.harvard.edu>
1208 William James Hall - Affective Neuroscience Lab
806 WJH, Social Neuroscience and Psychopathology Lab
Home: decklin at red-bean.com / Mobile: +1 860 978 4848

---

From: [email-masked] (Richard Heycock)
Date: Thu, 19 Jun 2008 08:21:06 +1000

Are you using ruby 1.8.7? I found this.

rgh

-- 
+61 (0) 410 646 369
[e]:  rgh at neoss.com.au
[im]: rgh at jabber.org

You're worried criminals will continue to penetrate into cyberspace, and
I'm worried complexity, poor design and mismanagement will be there to meet
them - Marcus Ranum

---

From: [email-masked] (Richard Heycock)
Date: Thu, 19 Jun 2008 10:35:45 +1000

Please disregard my last. I really mustn't reply to emails before my morning
coffee!

rgh

<snip>

-- 
+61 (0) 410 646 369
[e]:  rgh at neoss.com.au
[im]: rgh at jabber.org

---

From: [email-masked] (William Morgan)
Date: Thu, 19 Jun 2008 10:55:11 -0700

> second one (defaults to false; see docs). But this only happened recently

That makes sense. Either the second argument, or the fact that
Array#flatten uses both arguments, is what's changed in 1.8.7.

I've merged the patch directly into master.

> Also: Hi everyone. I am the future Debian maintainer of sup.

Whoo!
-- 
William <wmorgan-sup at masanjin.net>