Subject: [sup-talk] Patch for using default colors

From: [email-masked] (Mark Alexander)
Date: Sat, 21 Mar 2009 05:57:33 -0700

I noticed that sup wasn't using my terminal's
default colors when displaying the text of
a message.  Instead of the expected black on
light-yellow (my defaults), it was using white on black.
I also see a message in the mailing list archives
from Jan 29 titled "When using 'default' in colors.yaml
or colormap.rb, sup throws an exception" that seems
to describe the same problem.

I have attached a patch that works for me, and might
be a workaround for the other problem as well.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: defaultcolors.patch
Type: text/x-patch
Size: 281 bytes
Desc: not available
URL: <http://rubyforge.org/pipermail/sup-talk/attachments/20090321/3756fefe/attachment.bin>

---

From: [email-masked] (William Morgan)
Date: Mon, 23 Mar 2009 08:12:55 -0700

Reformatted excerpts from Mark Alexander's message of 2009-03-21:
> I noticed that sup wasn't using my terminal's default colors when
> displaying the text of a message.  Instead of the expected black on

Thanks for the patch. I've started a topic branch called default-colors.
Currently using this patch makes Sup look crazy for me, so I haven't
merged it into next.

I think the problem is the Sup is setting the background color to be
black. Parts of the screen have the "ncurses default" and parts of it
have black. I do think it's a step in the right direction though.

> I also see a message in the mailing list archives from Jan 29 titled
> "When using 'default' in colors.yaml or colormap.rb, sup throws an
> exception" that seems to describe the same problem.

This is a different problem, having to do with Sup's notion of a default
color. From what I recall it was a YAML issue or something.
-- 
William <wmorgan-sup at masanjin.net>

---

From: [email-masked] (William Morgan)
Date: Mon, 23 Mar 2009 08:25:05 -0700

Reformatted excerpts from William Morgan's message of 2009-03-23:
> This is a different problem, having to do with Sup's notion of a
> default color. From what I recall it was a YAML issue or something.

Nope, I was misremembering. You were right on the money---that was a
related bug. In fact, it contained the other half of the solution.

I've merged default-colors into next. Give it a shot.
-- 
William <wmorgan-sup at masanjin.net>

---

From: [email-masked] (Mark Alexander)
Date: Mon, 23 Mar 2009 09:34:51 -0700

> Currently using this patch makes Sup look crazy for me, so I haven't

I half-expected it would look bad for you.  I may be seeing the same
thing, but without defining it as "crazy" :-) .  For example, when
viewing a short message, I see the text of the message in the proper
default colors.  But the blank space below it is all black.  I can
live with that, but it's clearly not ideal.

---

From: [email-masked] (William Morgan)
Date: Wed, 25 Mar 2009 09:02:24 -0700

> live with that, but it's clearly not ideal.

This should be fixed in next. LMK if not.
-- 
William <wmorgan-sup at masanjin.net>