Subject: [sup-talk] Patch for message-id problem

From: [email-masked] (Mark Alexander)
Date: Fri, 20 Mar 2009 10:11:37 -0700

Here's a patch for the message-id problem I mentioned
earlier, where the header line was split into two lines:

Message-ID:
 <D3C12B2AD838B44DA9D6B2CA334246D011E72A73A4 at PA-EXMBX04.widget.com>

I've also seen other header lines that were split in this way,
so this patch works for them too.

I've added a somewhat large test case to the unit test
that is an exact copy of a message that was causing
me problems, but with the company name changed to protect
the innocent.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: msgid.patch
Type: application/octet-stream
Size: 4830 bytes
Desc: not available
URL: <http://rubyforge.org/pipermail/sup-talk/attachments/20090320/9debd13d/attachment.obj>

---

From: [email-masked] (William Morgan)
Date: Sun, 22 Mar 2009 09:59:59 -0700

Reformatted excerpts from Mark Alexander's message of 2009-03-20:
> Here's a patch for the message-id problem I mentioned earlier, where
> the header line was split into two lines:

Thanks! I've modified this slightly so that the regex looks like:

  HEADER_RE = /\s*(.*?)\s*/

which I believe is equivalent to your change.

I've applied the patch directly to master and that will probably be the
last thing going in before an 0.7 release.

> I've added a somewhat large test case to the unit test that is an
> exact copy of a message that was causing me problems, but with the
> company name changed to protect the innocent.

Very useful. Thanks!

A minor comment: for future patches, it will be easier for me to apply
your changes if you use git format-patch instead of git diff.
-- 
William <wmorgan-sup at masanjin.net>