Subject: [sup-talk] updated before-poll hook for offlineimap

From: [email-masked] (Gaute Hope)
Date: Wed, 09 Sep 2009 10:49:21 +0200

Greetings,

Here's an updated before-poll.rb hook for offlineimap working with
latest git. I'm suppressing some nasty python deprecation errors as
well.

before-poll.rb:
def offlineimap(*folders)
  cmd = "offlineimap -u Noninteractive.Basic 2>&1"
  cmd << " -f #{folders * ','}" unless folders.compact.empty?
  `#{cmd}`
end

def folder_names(sources)
  sources.map { |s| s.uri.split('/').last }
end

def inbox_sources(sources = SourceManager.sources)
  sources.find_all { |s| !s.archived? }.sort_by {|s| s.id }
end

if (@last_fetch || Time.at(0)) < Time.now - 120
  say "Running offlineimap..."
  # only check non-auto-archived sources on the first run
  log offlineimap(@last_fetch ? nil : folder_names(inbox_sources))
  say "Finished offlineimap."
end
@last_fetch = Time.now

Cheers, Gaute
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://rubyforge.org/pipermail/sup-talk/attachments/20090909/1b71019d/attachment.bin>

---

From: [email-masked] (Gaute Hope)
Date: Wed, 09 Sep 2009 19:37:29 +0200

Greetings,

It seems like the before-poll.rb hooks is not run when i manually poll
for messages; pressing P. Could this be correct?

Running 8903cdedc81

- gaute

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://rubyforge.org/pipermail/sup-talk/attachments/20090909/ea954818/attachment.bin>

---

From: [email-masked] (William Morgan)
Date: Thu, 10 Sep 2009 07:34:01 -0700

> for messages; pressing P. Could this be correct?

It should be. Are you sure the before-poll hook isn't dying the first
time it's run (automatically), causing Sup to skip it the second time
(when you press P)? You can look in the log buffer.

If that's not the case, can you confirm that PollManager#poll gets
invoked in both cases?
-- 
William <wmorgan-sup at masanjin.net>