Subject: [sup-talk] [PATCH] Use read instead of readlines.join.

From: [email-masked] (Nicolas Pouillard)
Date: Fri, 4 Apr 2008 18:00:56 +0200

---
 lib/sup/draft.rb                   |    2 +-
 lib/sup/hook.rb                    |    2 +-
 lib/sup/maildir.rb                 |    2 +-
 lib/sup/modes/file-browser-mode.rb |    2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/lib/sup/draft.rb b/lib/sup/draft.rb
index 81c0044..21de151 100644
--- a/lib/sup/draft.rb
+++ b/lib/sup/draft.rb
@@ -106,7 +106,7 @@ class DraftLoader < Source
   end
 
   def raw_message offset
-    IO.readlines(fn_for_offset(offset)).join
+    IO.read(fn_for_offset(offset))
   end
 
   def start_offset; 0; end
diff --git a/lib/sup/hook.rb b/lib/sup/hook.rb
index 74ecfab..9494919 100644
--- a/lib/sup/hook.rb
+++ b/lib/sup/hook.rb
@@ -120,7 +120,7 @@ private
     unless @hooks.member? name
       @hooks[name] =
         begin
-          returning IO.readlines(fn_for(name)).join do
+          returning IO.read(fn_for(name)) do
             log "read '#{name}' from #{fn_for(name)}"
           end
         rescue SystemCallError => e
diff --git a/lib/sup/maildir.rb b/lib/sup/maildir.rb
index 584e657..620e8e2 100644
--- a/lib/sup/maildir.rb
+++ b/lib/sup/maildir.rb
@@ -72,7 +72,7 @@ class Maildir < Source
 
   def raw_message id
     scan_mailbox
-    with_file_for(id) { |f| f.readlines.join }
+    with_file_for(id) { |f| f.read }
   end
 
   def scan_mailbox opts={}
diff --git a/lib/sup/modes/file-browser-mode.rb b/lib/sup/modes/file-browser-mode.rb
index b49f3f4..b92468d 100644
--- a/lib/sup/modes/file-browser-mode.rb
+++ b/lib/sup/modes/file-browser-mode.rb
@@ -47,7 +47,7 @@ protected
     return unless f && f.file?
 
     begin
-      BufferManager.spawn f.to_s, TextMode.new(f.readlines.join)
+      BufferManager.spawn f.to_s, TextMode.new(f.read)
     rescue SystemCallError => e
       BufferManager.flash e.message
     end
-- 
1.5.5.rc3

---

From: [email-masked] (Nicolas Pouillard)
Date: Mon, 21 Apr 2008 10:02:59 +0200

What about this patch?

-- 
Nicolas Pouillard aka Ertai
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 194 bytes
Desc: not available
Url : http://rubyforge.org/pipermail/sup-talk/attachments/20080421/86548146/attachment.bin

---

From: [email-masked] (William Morgan)
Date: Tue, 22 Apr 2008 18:43:04 -0700

> What about this patch?

Applied directly to master, and sorry for the delay.

-- 
William <wmorgan-sup at masanjin.net>