Subject: [sup-talk] bugfix to message-chunks.rb

From: [email-masked] (Brendan O'Connor)
Date: Wed, 14 Nov 2007 08:17:28 +0000

I was getting some crashes and tracked it down to this line.  This patch makes
the crash go away, so I think it's a bugfix (local variable masking the
accessor?) but am not sure.

Index: lib/sup/message-chunks.rb
===================================================================
--- lib/sup/message-chunks.rb   (revision 698)
+++ lib/sup/message-chunks.rb   (working copy)
@@ -111,7 +111,7 @@
       @lines = lines.map { |l| l.chomp.wrap WRAP_LEN }.flatten # wrap
 
       ## trim off all empty lines except one
-      lines.pop while lines.last =~ /^\s*$/ 
+      @lines.pop while @lines.last =~ /^\s*$/ 
     end
 
     def inlineable?; true end

---

From: [email-masked] (William Morgan)
Date: Wed, 14 Nov 2007 07:53:36 -0800

Excerpts from Brendan O'Connor's message of Wed Nov 14 00:17:28 -0800 2007:
> I was getting some crashes and tracked it down to this line.  This
> patch makes the crash go away, so I think it's a bugfix (local
> variable masking the accessor?) but am not sure.

I believe you're right. Applied. Thanks!

-- 
William <wmorgan-sup at masanjin.net>