Subject: [sup-talk] [PATCH] Unbreak "bounce-command" hook (was referencing an nonexistent variable)

From: [email-masked] (Adeodato Simó)
Date: Sat, 11 Jul 2009 13:57:55 +0200

Signed-off-by: Adeodato Sim? <dato at net.com.org.es>
---
 lib/sup/modes/thread-view-mode.rb |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/sup/modes/thread-view-mode.rb b/lib/sup/modes/thread-view-mode.rb
index 759191e..737f6f1 100644
--- a/lib/sup/modes/thread-view-mode.rb
+++ b/lib/sup/modes/thread-view-mode.rb
@@ -204,7 +204,7 @@ EOS
       end
     end
 
-    cmd = case HookManager.run "bounce-command", :from => m.from, :to => to
+    cmd = case (hookcmd = HookManager.run "bounce-command", :from => m.from, :to => to)
           when nil, /^$/ then defcmd
           else hookcmd
           end + ' ' + to.map { |t| t.email }.join(' ')
-- 
1.6.3.3

---

From: [email-masked] (Ben Walton)
Date: Sat, 11 Jul 2009 10:28:58 -0400

>  1 files changed, 1 insertions(+), 1 deletions(-)

+1 for this.  Not sure how I managed to submit the original patch like
this, since I did test various forms of results returned from the
bounce-command hook...anyway, I've applied this and verified it.

-Ben
-- 
Ben Walton
Systems Programmer - CHASS
University of Toronto
C:416.407.5610 | W:416.978.4302

GPG Key Id: 8E89F6D2; Key Server: pgp.mit.edu
Contact me to arrange for a CAcert assurance meeting.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://rubyforge.org/pipermail/sup-talk/attachments/20090711/3b5d572f/attachment.bin>

---

From: [email-masked] (William Morgan)
Date: Mon, 27 Jul 2009 09:22:48 -0700

> bounce-command hook...anyway, I've applied this and verified it.

I don't see this in your bw/bounce_message branch. I'd like to remerge
that.
-- 
William <wmorgan-sup at masanjin.net>

---

From: [email-masked] (Ben Walton)
Date: Mon, 27 Jul 2009 12:25:52 -0400

> I don't see this in your bw/bounce_message branch. I'd like to remerge

Sorry.  I didn't publish the change, I thought it would be `git am`'d
from the original mail.  I applied it to my local running copy of next
though, which is what I was referring to.  I'll try to remember to
push things like this in the future.

-Ben

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://rubyforge.org/pipermail/sup-talk/attachments/20090727/85a7f7a7/attachment.bin>

---

From: [email-masked] (William Morgan)
Date: Mon, 27 Jul 2009 09:29:20 -0700

Reformatted excerpts from Ben Walton's message of 2009-07-27:
> from the original mail.

No problem. We can do it either way. I'll apply this patch directly.
-- 
William <wmorgan-sup at masanjin.net>

---

From: [email-masked] (Ben Walton)
Date: Mon, 27 Jul 2009 12:30:20 -0400

> push things like this in the future.

I've now `git am`'d and pushed on my development copy to
git://code.chass.utoronto.ca/bwalton-sup.git.  You should be able to
remerge the bw/bounce_message branch and get Adeodato's fix.

Thanks
-Ben

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://rubyforge.org/pipermail/sup-talk/attachments/20090727/eb249faf/attachment.bin>

---

From: [email-masked] (William Morgan)
Date: Mon, 27 Jul 2009 09:30:50 -0700

Applied, thanks!

---

From: [email-masked] (William Morgan)
Date: Mon, 27 Jul 2009 09:45:17 -0700

> remerge the bw/bounce_message branch and get Adeodato's fix.

Heh. :)