Subject: [sup-talk] [Crash] "thread_by_subject: true" leads to "wrong id called on nil"

From: [email-masked] (Alexandra Walford)
Date: Tue, 11 Mar 2008 14:45:43 +1000

Hi all,

I am getting frequent sup crashes with "wrong id called on nil" (using the
latest git master), when thread_by_subject is true.

The crash generally happens when the thread index is being built as a result of
a search, or when opening the inbox (which is really just another sort of
search).

I have managed to narrow down one particular crash to two messages sent to the
sup-talk list.  If I set up a new maildir containing only those two messages
and a new sup config, accepting all sup-config defaults and changing
thread_by_subject to true, then I can reproduce the crash reliably.  The second
message References: the first message, although the subjects are dissimilar.

I have attached the two messages, a transcript of my test case session
(including backtrace), and sup-exception-log.txt.  I am not yet familiar enough
with sup or ruby to offer a decent patch; my current fix just hides any thread
which will cause a crash, on line 208 of lib/sup/modes/thread-index-mode.rb in
git master, which is a hopeless workaround really.

Thanks,

Alexandra

-- 
alexandra at walford.id.au
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: message1.txt
Url: http://rubyforge.org/pipermail/sup-talk/attachments/20080311/3d1a1cb1/attachment.txt 
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: message2.txt
Url: http://rubyforge.org/pipermail/sup-talk/attachments/20080311/3d1a1cb1/attachment-0001.txt 
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: sup-exception-log.txt
Url: http://rubyforge.org/pipermail/sup-talk/attachments/20080311/3d1a1cb1/attachment-0002.txt 
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: sup-test-case.txt
Url: http://rubyforge.org/pipermail/sup-talk/attachments/20080311/3d1a1cb1/attachment-0003.txt

---

From: [email-masked] (Christopher Warrington)
Date: Tue, 11 Mar 2008 02:06:08 -0500

Alexandra Walford @ 2008-3-10 11:45:43 PM
"[sup-talk] [Crash] "thread_by_subject: true" leads to "wrong id  called on nil"" <mid:1205210652-sup-1364 at amethyst>

> I have managed to narrow down one particular crash to two messages
> sent to the sup-talk list. If I set up a new maildir containing only
> those two messages and a new sup config, accepting all sup-config
> defaults and changing thread_by_subject to true, then I can
> reproduce the crash reliably. The second message References: the
> first message, although the subjects are dissimilar.

Sorry! :-)

The first message was created with sup. The second with git's
send-email command. I've not looked at them closely, but the messages
may be malformed.

-- 
Christopher Warrington <chrisw at rice.edu>

"The next best thing to being clever is being able to quote someone
who is."
-Mary Poole
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 183 bytes
Desc: not available
Url : http://rubyforge.org/pipermail/sup-talk/attachments/20080311/3ee207f6/attachment.bin

---

From: [email-masked] (Michael Gurski)
Date: Tue, 11 Mar 2008 20:51:46 -0400

Excerpts from Christopher Warrington's message of Tue Mar 11 03:06:08 -0400 2008:
> "[sup-talk] [Crash] "thread_by_subject: true" leads to "wrong id  called on
> nil"" <mid:1205210652-sup-1364 at amethyst>
> 

Interestingly, the crashes I was seeing with the same error seem to
have disappeared now that I've disabled thread_by_subject as well.
Once I get past the huge amount of backlog in mail that I have (who'd
have thought getting married would eat into my copious free time?),
I'll rerun sup and try to get the debugging output from the patch that
I applied to create a sendme.txt when this happens.

Mike

-- 
Michael A. Gurski (opt. [first].)[last]@pobox.com  http://www.pobox.com/~[last]
1024R/39B5BADD PGP: 34 93 A9 94 B1 59 48 B7  17 57 1E 4E 62 56 45 70
1024D/1166213E GPG: 628F 37A4 62AF 1475 45DB  AD81 ADC9 E606 1166 213E
4096R/C0B4F04B GPG: 5B3E 75D7 43CF CF34 4042  7788 1DCE B5EE C0B4 F04B
Views expressed by the host do not reflect the staff, management or sponsors.

---

From: [email-masked] (William Morgan)
Date: Fri, 14 Mar 2008 11:51:31 -0700

Reformatted excerpts from Alexandra Walford's message of 2008-03-10:
> I am getting frequent sup crashes with "wrong id called on nil" (using
> the latest git master), when thread_by_subject is true.

The thread_by_subject stuff is broken and I have a patch to fix it, I
just haven't merged it in yet. I'll try and do this soon. In the mean
time, as you've discovered, turning off thread_by_subj is the
workaround.

-- 
William <wmorgan-sup at masanjin.net>

---

From: [email-masked] (Alexandra Walford)
Date: Sat, 15 Mar 2008 08:28:39 +1000

> time, as you've discovered, turning off thread_by_subj is the

Sounds good!  Thanks :)

---

From: [email-masked] (William Morgan)
Date: Mon, 17 Mar 2008 09:41:55 -0700

Reformatted excerpts from William Morgan's message of 2008-03-14:
> just haven't merged it in yet. I'll try and do this soon.

Ok, I've merged the changes into next. Enable thread-by-subject and see
what happens.

If you're still seeing messages with "Re: " subjects in separate
threads, try reindexing those messages.

---

From: [email-masked] (Alexandra Walford)
Date: Tue, 18 Mar 2008 22:35:24 +1000

> Ok, I've merged the changes into next. Enable thread-by-subject and see

Nice, I'll give it a go :)