Subject: [sup-talk] [PATCH] more inline GPG madness

From: [email-masked] (Michael Stapelberg)
Date: Thu, 01 Oct 2009 00:08:39 +0200

Hi,

browsing some older emails, I noticed that the inline GPG patch I sent earlier
was not completely correct. It only handled messages which were encrypted *and*
signed, but not messages which were signed only.

Attached comes a patch which fixes the behaviour. However (!) the patch is not
well aligned, the error case (else) is untested and should probably be handled
differently and the old_charset line can probably be written more elegantly in
ruby. By the way, the charset stuff is necessary to get the correct character
set for messages which are sent inline. I really start to dislike Thunderbird
and other crappy software for that :-\.

So, please, clean up the patch and merge it. I have also attached a message
which was sent using thunderbird and contains inline crypto. If the patch works
correctly, you should be able to open it and see some umlauts.

Best regards,
Michael
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: sign.txt
URL: <http://rubyforge.org/pipermail/sup-talk/attachments/20091001/f9f6851c/attachment.txt>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: inline-gpg.patch
Type: application/octet-stream
Size: 1394 bytes
Desc: not available
URL: <http://rubyforge.org/pipermail/sup-talk/attachments/20091001/f9f6851c/attachment.obj>

---

From: [email-masked] (Michael Stapelberg)
Date: Thu, 01 Oct 2009 19:27:40 +0200

Hi,

> and other crappy software for that :-\.

I am sorry for the confusion. Please do not merge this patch without close
review if these PGP headers are valid at all. Turns out the headers were
produced by a custom procmail rule I had forgotton about.

I will instead implement support for "correct" inline GPG.

Best regards,
Michael