Subject: [sup-talk] patch with keymaps for editing message headers

From: [email-masked] (Eyal Oren)
Date: Thu, 11 Oct 2007 18:19:17 +0200

Attached another small patch, adding keymaps to edit 'To:', 'Cc:', and 
'Subject:' field of messages. Again something small that I missed, coming from 
Mutt. 

Please let me know if you don't like my coding style (it feels very stupid, 
jumping fields this way, but I couldn't quickly see how to do it better), or if 
you don't like these kind of added features.

 -eyal
-------------- next part --------------
A non-text attachment was scrubbed...
Name: keymap-for-to-cc-subject.patch
Type: application/octet-stream
Size: 1480 bytes
Desc: not available
Url : http://rubyforge.org/pipermail/sup-talk/attachments/20071011/f2866c63/attachment.obj

---

From: [email-masked] (William Morgan)
Date: Thu, 01 Nov 2007 19:18:19 -0700

Excerpts from Eyal Oren's message of Thu Oct 11 09:19:17 -0700 2007:
> 'Subject:' field of messages. Again something small that I missed,
> coming from Mutt. 

Applied, thanks!

-- 
William <wmorgan-sup at masanjin.net>

---

From: [email-masked] (Marcus Williams)
Date: Fri, 02 Nov 2007 12:55:15 +0000

> > > 'Subject:' field of messages. Again something small that I missed,

This adds a method in edit-message-mode called "edit_field" with 1 
argument. reply-mode has an edit_field method that overrides this if you 
are replying so you get an exception as it gets called instead when you 
try to edit the field in reply mode.

It doesnt look like the reply mode edit_field method gets used anywhere 
so this might need to be removed or the edit-message-mode method needs 
renaming perhaps.

Marcus

---

From: [email-masked] (William Morgan)
Date: Fri, 02 Nov 2007 08:23:48 -0700

Excerpts from Marcus Williams's message of Fri Nov 02 05:55:15 -0700 2007:
> argument. reply-mode has an edit_field method that overrides this if
> you are replying so you get an exception as it gets called instead
> when you try to edit the field in reply mode.

Good catch. I renamed the original EditMessageMode#edit_field method
(which ReplyMode overrode) to edit_field_or_message, and forgot to check
subclasses.

Who needs unit tests when you have enough users pulling the SVN head?