Subject: [sup-talk] [PATCH] Fix a bug when forwarding and using crypto.

From: [email-masked] (Nicolas Pouillard)
Date: Fri, 4 Apr 2008 18:01:45 +0200

---
 lib/sup/modes/edit-message-mode.rb |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/sup/modes/edit-message-mode.rb b/lib/sup/modes/edit-message-mode.rb
index 3aad623..dd96002 100644
--- a/lib/sup/modes/edit-message-mode.rb
+++ b/lib/sup/modes/edit-message-mode.rb
@@ -324,7 +324,7 @@ protected
     ## do whatever crypto transformation is necessary
     if @crypto_selector && @crypto_selector.val != :none
       from_email = PersonManager.person_for(@header["From"]).email
-      to_email = (@header["To"] + @header["Cc"] + @header["Bcc"]).map { |p| PersonManager.person_for(p).email }
+      to_email = [@header["To"], @header["Cc"], @header["Bcc"]].flatten.compact.map { |p| PersonManager.person_for(p).email }
 
       m = CryptoManager.send @crypto_selector.val, from_email, to_email, m
     end
-- 
1.5.5.rc3

---

From: [email-masked] (William Morgan)
Date: Fri, 04 Apr 2008 10:44:53 -0700

> +      to_email = [@header["To"], @header["Cc"], @header["Bcc"]].flatten.compact.map { |p| PersonManager.person_for(p).email }

What was the bug?

-- 
William <wmorgan-sup at masanjin.net>

---

From: [email-masked] (Nicolas Pouillard)
Date: Sat, 05 Apr 2008 12:39:29 +0200

> > +      to_email = [@header["To"], @header["Cc"], @header["Bcc"]].flatten.compact.map { |p| PersonManager.person_for(p).email }

When  some  of  these @header[...] are not present I get a nil and then get an
error when using '+' on them.

-- 
Nicolas Pouillard aka Ertai
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 194 bytes
Desc: not available
Url : http://rubyforge.org/pipermail/sup-talk/attachments/20080405/863f13ca/attachment.bin

---

From: [email-masked] (Nicolas Pouillard)
Date: Wed, 23 Apr 2008 11:04:48 +0200

What about this patch?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 194 bytes
Desc: not available
Url : http://rubyforge.org/pipermail/sup-talk/attachments/20080423/01052d0f/attachment.bin