Subject: [sup-talk] [PATCH] Wrap text attachments

From: [email-masked] (Israel Herraiz)
Date: Tue, 04 Nov 2008 01:08:41 +0100

Hi,

this patch wrap text attachaments, as well as messages. For me is
quite annoying to have to scroll to see the text attachments. Perhaps
it is useful for others too.

Cheers,
Israel

---
 lib/sup/message-chunks.rb |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/lib/sup/message-chunks.rb b/lib/sup/message-chunks.rb
index cc895f3..99bd12b 100644
--- a/lib/sup/message-chunks.rb
+++ b/lib/sup/message-chunks.rb
@@ -65,6 +65,8 @@ Return value:
 EOS
 #' stupid ruby-mode
 
+    WRAP_LEN = 80 # wrap text attachments at this width
+
     ## raw_content is the post-MIME-decode content. this is used for
     ## saving the attachment to disk.
     attr_reader :content_type, :filename, :lines, :raw_content
@@ -95,6 +97,7 @@ EOS
       @lines = nil
       if text
         @lines = text.gsub("\r\n", "\n").gsub(/\t/, "        ").gsub(/\r/, "").split("\n")
+        @lines = lines.map {|l| l.chomp.wrap WRAP_LEN}.flatten
         @quotable = true
       end
     end
-- 
1.5.6.5

---

From: [email-masked] (Nicolas Pouillard)
Date: Tue, 04 Nov 2008 14:29:40 +0100

Hi,

> it is useful for others too.

I have no opinion about this change.

However there is already a WRAP_LEN constant in this file, please provide
a patch that reuse the same constant.

Best regards,

-- 
Nicolas Pouillard aka Ertai

---

From: [email-masked] (Israel Herraiz)
Date: Tue, 04 Nov 2008 15:07:21 +0100

> a patch that reuse the same constant.

Find it below. I have moved the constant out of the Attachment and
Text classes, and it is now in the context of the Chunk module.

Cheers,
Israel

---
 lib/sup/message-chunks.rb |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/lib/sup/message-chunks.rb b/lib/sup/message-chunks.rb
index cc895f3..5b5c314 100644
--- a/lib/sup/message-chunks.rb
+++ b/lib/sup/message-chunks.rb
@@ -41,6 +41,8 @@ end
 
 module Redwood
 module Chunk
+  WRAP_LEN = 80 # wrap messages and text attachments at this width
+
   class Attachment
     HookManager.register "mime-decode", <<EOS
 Executes when decoding a MIME attachment.
@@ -95,6 +97,7 @@ EOS
       @lines = nil
       if text
         @lines = text.gsub("\r\n", "\n").gsub(/\t/, "        ").gsub(/\r/, "").split("\n")
+        @lines = lines.map {|l| l.chomp.wrap WRAP_LEN}.flatten
         @quotable = true
       end
     end
@@ -143,7 +146,6 @@ EOS
   end
 
   class Text
-    WRAP_LEN = 80 # wrap at this width
 
     attr_reader :lines
     def initialize lines
-- 
1.5.6.5

---

From: [email-masked] (William Morgan)
Date: Fri, 07 Nov 2008 08:55:56 -0800

> Text classes, and it is now in the context of the Chunk module.

Applied, thanks!
-- 
William <wmorgan-sup at masanjin.net>