Subject: [sup-talk] to_time_s

From: [email-masked] (Andrei Maxim)
Date: Wed, 28 Nov 2007 04:19:43 +0200

Hi guys,

I just grabbed the latest sup using `sudo gem install sup` after seeing the
announce on RubyTalk, configured my Gmail account and did a `sup-sync` and
this is what I got:

[Wed Nov 28 03:50:30 +0200 2007] unlocking /Users/andrei/.sup/lock...
/usr/local/lib/ruby/gems/1.8/gems/sup-0.3/bin/sup-sync:14:in `to_i':
Infinity (FloatDomainError)
        from /usr/local/lib/ruby/gems/1.8/gems/sup-0.3/bin/sup-sync:14:in
`to_time_s'
        from /usr/local/lib/ruby/gems/1.8/gems/sup-0.3/bin/sup-sync:182
        from /usr/local/lib/ruby/gems/1.8/gems/sup-0.3/lib/sup/poll.rb:158:in
`add_messages_from'
        from /usr/local/lib/ruby/gems/1.8/gems/sup-0.3/lib/sup/imap.rb:170:in
`each'
        from /usr/local/lib/ruby/gems/1.8/gems/sup-0.3/lib/sup/imap.rb:158:in
`upto'
        from /usr/local/lib/ruby/gems/1.8/gems/sup-0.3/lib/sup/imap.rb:158:in
`each'
        from /usr/local/lib/ruby/gems/1.8/gems/sup-0.3/lib/sup/util.rb:533:in
`send'
        from /usr/local/lib/ruby/gems/1.8/gems/sup-0.3/lib/sup/util.rb:533:in
`__pass'
        from /usr/local/lib/ruby/gems/1.8/gems/sup-0.3/lib/sup/util.rb:522:in
`method_missing'
        from /usr/local/lib/ruby/gems/1.8/gems/sup-0.3/lib/sup/poll.rb:140:in
`add_messages_from'
        from /usr/local/lib/ruby/gems/1.8/gems/sup-0.3/lib/sup/util.rb:496:in
`send'
        from /usr/local/lib/ruby/gems/1.8/gems/sup-0.3/lib/sup/util.rb:496:in
`method_missing'
        from /usr/local/lib/ruby/gems/1.8/gems/sup-0.3/bin/sup-sync:134
        from /usr/local/lib/ruby/gems/1.8/gems/sup-0.3/bin/sup-sync:129:in
`each'
        from /usr/local/lib/ruby/gems/1.8/gems/sup-0.3/bin/sup-sync:129
        from /usr/local/bin/sup-sync:16:in `load'
        from /usr/local/bin/sup-sync:16

Here's the line of the code that's causing the issues:

$stderr.puts "## #{num_scanned} (#{pctdone}%) read; #{elapsed.to_time_s}
elapsed; #{remaining.to_time_s} remaining"

It seems that the time difference is way too big. The mailbox is not so big,
around 400 MB according to Gmail, but I have a couple of months of high
traffic emails like Rails and RubyTalk. Sup detects that I have 66844 emails
in the INBOX folder.

If needed, I could send a patch.

-- 
Andrei Maxim
http://andreimaxim.ro
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://rubyforge.org/pipermail/sup-talk/attachments/20071128/d0463ad2/attachment-0001.html

---

From: [email-masked] (William Morgan)
Date: Wed, 28 Nov 2007 09:08:45 -0800

> Infinity (FloatDomainError)

Heh. Does this patch help?

--- bin/sup-sync        (revision 731)
+++ bin/sup-sync        (working copy)
@@ -7,6 +7,9 @@
 
 class Float
   def to_s; sprintf '%.2f', self; end
+  def to_time_s
+    infinite? ? "unknown" : super
+  end
 end

-- 
William <wmorgan-sup at masanjin.net>

---

From: [email-masked] (Andrei Maxim)
Date: Thu, 29 Nov 2007 02:58:33 +0200

> +++ bin/sup-sync        (working copy)

I have decided to delete most of the emails and it worked ok. But thanks for
the patch :)

-- 
Andrei Maxim
http://andreimaxim.ro
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://rubyforge.org/pipermail/sup-talk/attachments/20071129/57c172b4/attachment.html