Subject: [sup-talk] Crash when deleting an email from person-search-results-mode

From: [email-masked] (Pierre Baillet)
Date: Wed, 14 Nov 2007 00:00:06 +0100

Hi there,

while playing with the contact manager (shouldn't tab look for
"*typedstring* instead of "typedstring*" when selecting TO recipients ?), I
did a search "S" on one of my contact. Sup brought back one email which I
could read by pressing enter. However, as soon as i typed d to delete the
email, sup crashed :

The problem was: 'no implicit conversion from nil to integer' (error type
TypeError)
A backtrace follows:
/home/oct/temp/sup_trunk/lib/sup/modes/thread-index-mode.rb:483:in
`delete_at': no implicit conversion from nil to integer (TypeError)
        from /home/oct/temp/sup_trunk/lib/sup/modes/thread-index-mode.rb:483:in
`hide_thread'
        from /usr/lib/ruby/1.8/thread.rb:135:in `synchronize'
        from /home/oct/temp/sup_trunk/lib/sup/modes/thread-index-mode.rb:479:in
`hide_thread'
        from /home/oct/temp/sup_trunk/lib/sup/modes/thread-index-mode.rb:126:in
`handle_deleted_update'
        from /home/oct/temp/sup_trunk/lib/sup/update.rb:16:in `send'
        from /home/oct/temp/sup_trunk/lib/sup/update.rb:16:in `relay'
        from /home/oct/temp/sup_trunk/lib/sup/update.rb:16:in `each'
        from /home/oct/temp/sup_trunk/lib/sup/update.rb:16:in `relay'
         ... 7 levels...
        from /home/oct/temp/sup_trunk/lib/sup/mode.rb:54:in `send'
        from /home/oct/temp/sup_trunk/lib/sup/mode.rb:54:in `handle_input'
        from /home/oct/temp/sup_trunk/lib/sup/buffer.rb:203:in
`handle_input'
        from /home/oct/temp/sup_trunk/bin/sup:208

I had just synchronised my sup with my mailbox. From the backtrace, I
suspect that this is the redraw of the updated (now empty) result list that
poses problem, but i didn't look into it very much...

-- 
Pierre Baillet <pierre at baillet.name>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://rubyforge.org/pipermail/sup-talk/attachments/20071114/f5b6822f/attachment.html

---

From: [email-masked] (William Morgan)
Date: Wed, 14 Nov 2007 09:07:04 -0800

Excerpts from Pierre Baillet's message of Tue Nov 13 15:00:06 -0800 2007:
> "*typedstring* instead of "typedstring*" when selecting TO recipients
> ?)

Prefix match is more what I'm used to in console apps, but infix match
is what Gmail does. Vim does infix match on tab-completion for things
like switching buffers, so it's not unheard of...

What do people think?

> I did a search "S" on one of my contact. Sup brought back one email
> which I could read by pressing enter. However, as soon as i typed d to
> delete the email, sup crashed :

This should be fixed in SVN now. Thanks!

-- 
William <wmorgan-sup at masanjin.net>

---

From: [email-masked] (Nicolas Pouillard)
Date: Wed, 14 Nov 2007 18:39:10 +0100

> like switching buffers, so it's not unheard of...

I would prefer infix match.

What about using prefix match when the query starts with a '^'?

Regards,
-- 
Nicolas Pouillard aka Ertai

---

From: [email-masked] (vasudeva)
Date: Wed, 14 Nov 2007 19:36:25 -0500

> I would prefer infix match.

Same.

> What about using prefix match when the query starts with a '^'?

This smacks of sensibility.

/></

--
linkswarm.com :: Collaborative Insolence
vasudeva.linkswarm.com/gallery :: For The Faint of Heart