Subject: [sup-talk] [PATCH] don't downcase names before looking them up in the alias to person map, since keys in that map aren't downcased.

From: [email-masked] (Steve Goldman)
Date: Fri, 07 Nov 2008 15:04:33 -0500

---
We shouldn't downcase names before we look them up in the alias to
person hash since the keys of that hash are case sensitive.  This
brings up a more philosophical question of whether keys in that hash
SHOULD be case sensitive.  What does it mean to have two aliases
"Steve" and "steve"?

 lib/sup/buffer.rb |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/sup/buffer.rb b/lib/sup/buffer.rb
index ebc3587..0447f61 100644
--- a/lib/sup/buffer.rb
+++ b/lib/sup/buffer.rb
@@ -506,7 +506,7 @@ EOS
     answer = BufferManager.ask_many_emails_with_completions domain, question, completions, default

     if answer
-      answer.split_on_commas.map { |x| ContactManager.contact_for(x.downcase) || PersonManager.person_for(x) }
+      answer.split_on_commas.map { |x| ContactManager.contact_for(x) || PersonManager.person_for(x) }
     end
   end

--
1.5.5
-- 

Steve Goldman
sgoldman at tower-research.com

T: 212.219.6014
F: 212.219.6007

Tower Research Capital, LLC
377 Broadway, 11th Fl.
New York, NY 10013

---

From: [email-masked] (William Morgan)
Date: Sun, 09 Nov 2008 20:55:56 -0800

> SHOULD be case sensitive.  What does it mean to have two aliases

Certainly, either everything should be case sensitive, or everything
should be case insensitive. The problem here was that creating aliases
was case sensitive, but looking them up wasn't.

Personally I'm fine with case-sensitive aliases. Applied, thanks!
-- 
William <wmorgan-sup at masanjin.net>