Subject: [sup-talk] About newlines

From: [email-masked] (Nicolas Pouillard)
Date: Fri, 04 Apr 2008 14:14:06 +0200

I'm  hitting  a  bug  concerning forwarding, all newlines get trimmed off. I'm
trying  to fix the bug, but I don't understand if arrays of lines are supposed
to be ended by newlines or not.

-- 
Nicolas Pouillard aka Ertai
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 194 bytes
Desc: not available
Url : http://rubyforge.org/pipermail/sup-talk/attachments/20080404/acbb1193/attachment.bin

---

From: [email-masked] (William Morgan)
Date: Fri, 04 Apr 2008 09:08:02 -0700

Reformatted excerpts from nicolas.pouillard's message of 2008-04-04:
> I'm  hitting  a  bug  concerning forwarding, all newlines get trimmed
> off. I'm trying  to fix the bug, but I don't understand if arrays of
> lines are supposed to be ended by newlines or not.

I don't see this behavior, either in the forward mode buffer or in the
resulting message.

Newlines shouldn't exist in arrays of lines.
ForwardMode#forward_body_lines is the relevant method. Let me know what
you discover.

-- 
William <wmorgan-sup at masanjin.net>

---

From: [email-masked] (Nicolas Pouillard)
Date: Fri, 04 Apr 2008 18:10:11 +0200

Excerpts from William Morgan's message of Fri Apr 04 18:08:02 +0200 2008:> Reformatted excerpts from nicolas.pouillard's message of 2008-04-04:> > I'm  hitting  a  bug  concerning forwarding, all newlines get trimmed> > off. I'm trying  to fix the bug, but I don't understand if arrays of> > lines are supposed to be ended by newlines or not.> > I don't see this behavior, either in the forward mode buffer or in the> resulting message.> > Newlines shouldn't exist in arrays of lines.> ForwardMode#forward_body_lines is the relevant method. Let me know what> you discover.I hope that my bunch of patches will makes this clear.-- Nicolas Pouillard aka Ertai
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 194 bytes
Desc: not available
Url : http://rubyforge.org/pipermail/sup-talk/attachments/20080404/ca47ba3b/attachment.bin

---

From: [email-masked] (Marc Hartstein)
Date: Fri, 04 Apr 2008 12:16:09 -0400

> to be ended by newlines or not.

After a bit of chat in #sup on freenode, I have a workaround and some
comments.

Workaround (tested): make sure you instruct your editor to save the
temporary file even when you are making no changes.  This will force sup
to capture the contents of the file, which will include the newlines.

New bug: the same bug exists when replying if you don't edit your
message before sending (why would you ever do that?)

The problem seems to be that when the body of forward/reply messages is
built, it is built without a newline terminator at the end of every
line.  This is infrequently noticed because those newlines get added to
the temporary file for editing.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://rubyforge.org/pipermail/sup-talk/attachments/20080404/0ecde927/attachment.bin