Subject: [sup-talk] [PATCH] Fix for icon title in gnome terminal (possibly others)

From: [email-masked] (Marcus Williams)
Date: Wed, 05 Mar 2008 10:11:13 +0000

The escape code used for terminal titles works mostly but it doesnt set
the icon title as well [1], which is useful when minimised. This patch makes
the escape code set both window and icon title so the task bar updates
correctly in the gnome terminal (and probably others).

[1] http://rtfm.etla.org/xterm/ctlseq.html (see Operating System Controls)
---
 lib/sup/buffer.rb |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/sup/buffer.rb b/lib/sup/buffer.rb
index d40a626..978e104 100644
--- a/lib/sup/buffer.rb
+++ b/lib/sup/buffer.rb
@@ -263,7 +263,7 @@ EOS
         get_status_and_title @focus_buf # must be called outside of the ncurses lock
       end
 
-    print "\033]2;#{title}\07" if title && @in_x
+    print "\033]0;#{title}\07" if title && @in_x
 
     Ncurses.mutex.lock unless opts[:sync] == false
 
-- 
1.5.4.1

---

From: [email-masked] (William Morgan)
Date: Wed, 26 Mar 2008 09:11:49 -0700

Reformatted excerpts from Marcus Williams's message of 2008-03-05:
> The escape code used for terminal titles works mostly but it doesnt
> set the icon title as well [1], which is useful when minimised. This
> patch makes the escape code set both window and icon title so the task
> bar updates correctly in the gnome terminal (and probably others).

Reworked slightly (to avoid duplicating the conditional) and applied.
Thanks!

-- 
William <wmorgan-sup at masanjin.net>

---

From: [email-masked] (Marcus Williams)
Date: Tue, 01 Apr 2008 11:07:06 +0100

> Reworked slightly (to avoid duplicating the conditional) and applied.

I couldnt figure out what you meant when you said this but I just
checked the diff that went in and that explained it... My patch
removes the old escape code line and replaces it with a single line,
but your patch prints both escape codes. You only need the one in my
patch as that does both icon and window titles, so you should be able
to have the single line:

print "\033]0;#{title}\07" if title && @in_x

... the fifth char '0' in the escape code means window AND icon (1
would be icon, 2 would be window). Not sure if you misread the patch
or if I duffed up :)

Marcus

---

From: [email-masked] (William Morgan)
Date: Tue, 01 Apr 2008 08:03:02 -0700

Reformatted excerpts from Marcus Williams's message of 2008-04-01:
> Not sure if you misread the patch or if I duffed up :)

I misread the patch. Sorry about that! Should be fixed now.