Subject: [sup-talk] [PATCH] Make logging less chatty

From: [email-masked] (Edward Z. Yang)
Date: Mon, 27 Jul 2009 13:39:27 -0400

Sup currently generates a lot of logging spew during initial startup
when it is threading.  This makes it difficult to see other log
messages that are more interesting.  I propose we turn these messages
off.

>From 1fc4107013a991f24a62dad54509913bb1270d5d Mon Sep 17 00:00:00 2001
From: Edward Z. Yang <ezyang at mit.edu>
Date: Sat, 25 Jul 2009 14:16:40 -0400
Subject: [PATCH] Make logging less chatty.

Signed-off-by: Edward Z. Yang <ezyang at mit.edu>
---
 lib/sup/index.rb |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/sup/index.rb b/lib/sup/index.rb
index 9c985d9..fa33baa 100644
--- a/lib/sup/index.rb
+++ b/lib/sup/index.rb
@@ -394,10 +394,10 @@ EOS
     end
 
     if killed
-      Redwood::log "thread for #{m.id} is killed, ignoring"
+      #Redwood::log "thread for #{m.id} is killed, ignoring"
       false
     else
-      Redwood::log "ran #{num_queries} queries to build thread of #{messages.size} messages for #{m.id}: #{m.subj}" if num_queries > 0
+      #Redwood::log "ran #{num_queries} queries to build thread of #{messages.size} messages for #{m.id}: #{m.subj}" if num_queries > 0
       messages.each { |mid, builder| yield mid, builder }
       true
     end
-- 
1.6.3.3

---

From: [email-masked] (Ben Walton)
Date: Mon, 27 Jul 2009 13:48:05 -0400

> messages that are more interesting.  I propose we turn these messages

+1 for the idea, but wouldn't a command line verbosity toggle be a
better way to do this?  Maybe an arg that accepts a numeric value and
then debug statements of type foo if $val > bar?

Makes debugging this stuff easier, but the output is still optional
and presumably below the default threshold.

Just a thought.

-Ben
-- 
Ben Walton
Systems Programmer - CHASS
University of Toronto
C:416.407.5610 | W:416.978.4302

GPG Key Id: 8E89F6D2; Key Server: pgp.mit.edu
Contact me to arrange for a CAcert assurance meeting.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://rubyforge.org/pipermail/sup-talk/attachments/20090727/60963ec8/attachment.bin>

---

From: [email-masked] (William Morgan)
Date: Tue, 28 Jul 2009 08:25:23 -0700

Reformatted excerpts from Ben Walton's message of 2009-07-27:
> better way to do this?

I've applied the patch, but yes, the whole Redwood::log thing is crufty
and needs to be replaced with a logger that's aware of levels.
-- 
William <wmorgan-sup at masanjin.net>

---

From: [email-masked] (Mark Alexander)
Date: Tue, 28 Jul 2009 12:57:57 -0400

On 7/28/09, William Morgan <wmorgan-sup at masanjin.net> wrote:
> ... but yes, the whole Redwood::log thing is crufty

Or maybe something combining types and levels that you
could configure like this in config.yaml:

:logging:
  :mbox: 2
  :maildir: 3
  :ferret: 0
  ...etc...