Subject: Re: [sup-talk] Feature Request: Collecting Lines in Index Mode

From: Christian Dietrich <[email-masked]>
Date: Mon, 12 Oct 2009 21:23:48 +0200

Excerpts from Christian Dietrich's message of Mo Okt 12 09:11:35 +0200 2009:
> Excerpts from Gaute Hope's message of Fr Okt 09 13:00:19 +0200 2009:
> > Or the thread count isn't aware of the Today mark and still thinks line
> > 2 is thread 2? Don't really know anything about the implementation.
> > 
> > When it happens it doesn't dissapear before I do a M or there is a pull
> > that redraws the screen.. just pressing Ctrl+L or opening/closing a
> > thread doesn't remove it.
> > 
> > As said earlier it only seems to affect the top two threads.
> 
> Hi,
> i also experienced now this Problem, but can't see were this problem
> is located, because i don't touch the internal states of the
> threads. There must be one @thread[curpos] left, which causes this
> Problem.
> 
> greetz didi

Hi,
i think i've fixed the problem now, it was a wrong mapping in
update_text_for_line, now the situation that caused the error before
succeeds. There was a misguiding declaration of @size_widgets in the
init function.

@size_widgets isn't a Hash, mapping line numbers to a size_widget,
it is the same index as in @threads for the specific thread.

greetz didi

PS: please pull :-)
-- 
No documentation is better than bad documentation
-- Das Ausdrucken dieser Mail wird urheberrechtlich verfolgt.
_______________________________________________
sup-talk mailing list
[email-masked]
http://rubyforge.org/mailman/listinfo/sup-talk

---

From: Christian Dietrich <[email-masked]>
Date: Fri, 09 Oct 2009 09:19:30 +0200

> And 't' should select the next thread, not the next line. 'a' and 'A'
> too, in fact a time tag should only be selectable manually, using
> Up/Down or 'j'/'k'. Or never if collapsing/expending is possible with a
> mapping (my vote goes to 'E').

Jep thats right, i fixed that. Please pull.

greetz didi

---

From: Christian Dietrich <[email-masked]>
Date: Thu, 08 Oct 2009 09:05:47 +0200

Excerpts from Christian Dietrich's message of Fr Okt 02 22:48:24 +0200 2009:
> Thank you, that helped a much. I implemented the feature, it is
> available at git://github.com/stettberger/sup-mail.git
> branch time_marks, it is one commit ahead of next. It is enabled
> with setting the config option ":time_markers_in_index_mode: true"
> At runtime it can be toggled via '%' (just randomly choosen by me)

Ok now i did a little bit of reworking the code (don't make it sup
crash :-) and added a little bit color). The is now
:time_marker_color. I attached a screenshot of the time_marks.

greetz didi

---

From: Gaute Hope <[email-masked]>
Date: Thu, 08 Oct 2009 21:44:30 +0200

Excerpts from Christopher Bertels's message of to. okt. 08 21:33:44 +0200 2009:
> Excerpts from Christian Dietrich's message of Do Okt 08 20:28:59 +0200 2009:
> > Yeah thats cool, i implemented it, just type <Enter> on a Time Mark
> > (after pulling)
> 
> Indeed, very nice. Thanks :)
> I'd like to see this in sup's mainline, btw :)

+1 ! Looks great!

- gaute

---

From: Christopher Bertels <[email-masked]>
Date: Thu, 08 Oct 2009 14:31:24 +0200

> :time_marker_color. I attached a screenshot of the time_marks.

Looks really cool, I'll give it a try :)
-- 
================================
Christopher Bertels
http://www.adztec-independent.de
GPG Key ID: 0x2345b203
_______________________________________________
sup-talk mailing list
[email-masked]
http://rubyforge.org/mailman/listinfo/sup-talk

---

From: Christian Dietrich <[email-masked]>
Date: Fri, 09 Oct 2009 09:44:02 +0200

Excerpts from Gaute Hope's message of Fr Okt 09 09:31:38 +0200 2009:
> This doesn't work for me: '1'/'^' just makes the view scroll one down; hiding
> the
> Today marker (same as hitting 'J' one time). 0 works like expected.
> 
> a/A/&/d/S/t and E seems to be working alright.

Yeah ok, that should be fixed now. (I didn't even now about this
keystroke before...)

greetz didi

---

From: Benoît PIERRE <[email-masked]>
Date: Thu, 08 Oct 2009 22:26:12 +0200

Excerpts from Gaute Hope's message of Thu Oct 08 22:12:31 +0200 2009:
> Excerpts from Gaute Hope's message of to. okt. 08 21:44:30 +0200 2009:
> Would be nice if the '1' keybinding would select the first message and
> not the first line. Possibly another binding to collapse the current day when
> a message is selected (maybe h or E to keep things similar to the
> message view)?

Cheers,
-- 
A: Because it destroys the flow of conversation.
Q: Why is top posting dumb?
_______________________________________________
sup-talk mailing list
[email-masked]
http://rubyforge.org/mailman/listinfo/sup-talk

---

From: Christian Dietrich <[email-masked]>
Date: Mon, 12 Oct 2009 09:11:35 +0200

Hi,

greetz didi

---

From: Gaute Hope <[email-masked]>
Date: Fri, 09 Oct 2009 13:00:19 +0200

Excerpts from Christian Dietrich's message of fr. okt. 09 12:39:27 +0200 2009:
> Excerpts from Gaute Hope's message of Fr Okt 09 12:12:21 +0200 2009:
> > Excerpts from Gaute Hope's message of fr. okt. 09 11:45:13 +0200 2009:
> > > Not entierly sure what caused it since I can't really reproduce it by
> > > sending myself emails.. if it happens again ill post screenshot.
> > > 
> > > Im using time_marker branch rebased ontop of origin/next.
> > 
> > Ok.. now the top message count just got copied down to the line
> > beneath (which should be empty). Sup had just been running for a while,
> > no new messages, didn't happen on first pool..
> 
> I have no idea whats causing this, seems like the data of two
> threads is mixed together?

- gaute

---

From: Benoît PIERRE <[email-masked]>
Date: Thu, 08 Oct 2009 22:04:10 +0200

Excerpts from Christian Dietrich's message of Thu Oct 08 20:28:59 +0200 2009:
> Excerpts from Christopher Bertels's message of Do Okt 08 14:44:32 +0200 2009:
> > Ok, I like it so far. But what would really rock (IMO) would be the
> > possibility to collapse all messages, that are from yesterday or 2
> > weeks ago etc.
> > What do you think?
> 

This is great, I love it. Attached 2 small patches:
- fix a warning (space before opening parenthesis in function call)
- fix a bug with thread selection when time marks are not visible

Cheers,

---

From: Gaute Hope <[email-masked]>
Date: Fri, 09 Oct 2009 09:31:38 +0200

Excerpts from Christian Dietrich's message of to. okt. 08 22:50:07 +0200 2009:
> Yeah, implemented that, and the other two patches in the branch,
> like the idea.

This doesn't work for me: '1'/'^' just makes the view scroll one down; hiding the
Today marker (same as hitting 'J' one time). 0 works like expected.

- gaute

---

From: Christian Dietrich <[email-masked]>
Date: Thu, 08 Oct 2009 22:50:07 +0200

greetz didi

---

From: Gaute Hope <[email-masked]>
Date: Fri, 09 Oct 2009 12:12:21 +0200

- gaute

---

From: Gaute Hope <[email-masked]>
Date: Thu, 08 Oct 2009 22:12:31 +0200

- gaute

---

From: Christopher Bertels <[email-masked]>
Date: Thu, 08 Oct 2009 14:44:32 +0200

---

From: Christian Dietrich <[email-masked]>
Date: Thu, 08 Oct 2009 20:28:59 +0200

greetz didi

---

From: Gaute Hope <[email-masked]>
Date: Fri, 09 Oct 2009 11:45:13 +0200

> Yeah ok, that should be fixed now. (I didn't even now about this

Just discovered a weird bug.. when this thread got polled and updated
the message count, in this case (13), got attached to the thread
beneath, which only had one message, and appeared where it shouldn't be
anything.. the top thread didn't have any post count. It seemed to only
have affected the top two messages, as the count on the third one seemed
normal.

- gaute

---

From: Christopher Bertels <[email-masked]>
Date: Thu, 08 Oct 2009 21:33:44 +0200

---

From: Christian Dietrich <[email-masked]>
Date: Fri, 09 Oct 2009 12:39:27 +0200

greetz didi