Subject: [sup-devel] [PATCH] Avoid O(n^2) complexity for maildir deduplication.

From: "Edward Z. Yang" <[email-masked]>
Date: Wed, 19 Jan 2011 21:44:56 -0500

Signed-off-by: Edward Z. Yang <[email-masked]>
---
 lib/sup/maildir.rb |    9 ++++++---
 1 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/lib/sup/maildir.rb b/lib/sup/maildir.rb
index ba8efed..0898c91 100644
--- a/lib/sup/maildir.rb
+++ b/lib/sup/maildir.rb
@@ -128,14 +128,17 @@ class Maildir < Source
     ## deleted arrays, meaning that its flags changed or that it has
     ## been moved, these ids need to be removed from added and deleted
     add_to_delete = del_to_delete = []
+    map = {}
     added.each do |id_add|
-      deleted.each do |id_del|
-        if maildir_data(id_add)[0] == maildir_data(id_del)[0]
+        map[maildir_data(id_add)[0]] = id_add
+    end
+    deleted.each do |id_del|
+        id_add = maildir_data(id_del)[0]
+        if not id_add.nil?
           updated.push [ id_del, id_add ]
           add_to_delete.push id_add
           del_to_delete.push id_del
         end
-      end
     end
     added -= add_to_delete
     deleted -= del_to_delete
-- 
1.7.0.4

_______________________________________________
Sup-devel mailing list
[email-masked]
http://rubyforge.org/mailman/listinfo/sup-devel